gantt plugin#352
Merged
Merged
Conversation
roguisharcanetrickster
added
the
patch
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
from
49399a1 to
a1b37dd
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
3 times, most recently
from
22e308b to
667e19f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
3 times, most recently
from
1f166ee to
cd4e322
Compare
Collaborator
One of your class definitions isn't extending from the proper value. |
johnny-hausman
requested changes
May 26, 2026
johnny-hausman
left a comment
johnny-hausman
left a comment
Collaborator
There was a problem hiding this comment.
lets see if this fixes the tests.
| const UIClass = UI_Class(AB); | ||
| const L = UIClass.L(); | ||
| export default function (AB, ABUIPlugin, ibase) { | ||
| const UIClass = ABUIPlugin.ClassUI; |
Collaborator
There was a problem hiding this comment.
I think this should just be const UIClass = ABUIPlugin;.
I don't think there is a .ClassUI property on this.
so down below just use class ABObjectWorkspaceViewGant extends ABUIPlugin
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
4 times, most recently
from
7d7f47c to
2889567
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
from
2889567 to
8a0d2b2
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
4 times, most recently
from
a44c00d to
6782949
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
from
6782949 to
b3d5d58
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
from
ff587e8 to
329a5c7
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
from
329a5c7 to
1ff60b8
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
5 times, most recently
from
1a3be5b to
234a424
Compare
roguisharcanetrickster
force-pushed
the
rat/gantt_plugin
branch
from
234a424 to
03aa2f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.